He was one of the most popular Christian authors of his age writing over 60 books, booklets, and pamphlets. He served as a pastor for several decades in Pennsylvania and Illinois. He also served as Editorial Superintendent of the Presbyterian Board of Publication.